[PATCH] D147110: [symbolizer] Treat invalid address as addr2line does

Wed Mar 29 00:24:34 PDT 2023

jhenderson added a comment.

Mostly looks good to me, but please see inline comments.

================
Comment at: llvm/test/tools/llvm-symbolizer/input-base.test:29-30

-INVALID-NOT-OCTAL-LOWER: 0o1234
-INVALID-NOT-OCTAL-LOWER-NOT: ??
-
 INVALID-NOT-OCTAL-UPPER: 0O1234
 INVALID-NOT-OCTAL-UPPER-NOT: ??
+
----------------
These checks should be deleted, right?

================
Comment at: llvm/test/tools/llvm-symbolizer/invalid-input-address.test:20
+
+# Test bad input address values for the GNU-compatible version.
+RUN: llvm-addr2line --obj=%p/Inputs/addr.exe < %t.inp | FileCheck --check-prefix=GNU-BAD-INPUT %s
----------------
If I'm not mistaken, the different behaviour is controlled by the `--output-style` option and llvm-addr2line just happens to have the right default value for this to work. Is it worth explicitly testing `llvm-symbolizer --output-style=GNU` for this case?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147110/new/

https://reviews.llvm.org/D147110