[PATCH] D146136: [llvm][CycleInfo] Quick look-up for block in cycle.

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds added a comment.

In D146136#4223118 <https://reviews.llvm.org/D146136#4223118>, @Pierre-vh wrote:

> Though I would split this into two commits:
>
> - First, commit the CycleInfo change, but use the const_cast and the current API (no SetVector change)
> - Then, commit the QoL change to SetVector's API.
>
> That way, if someone, someday says that this change is heresy, it can very easily be reverted without having to understand the rest of this patch.

Well, they can't revert the change to SetVector because the change to CycleInfo will depend on it! And the "rest of the patch" is really just a well-defined use-case for the change to SetVector. Submitting as a single patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146136/new/

https://reviews.llvm.org/D146136