[PATCH] D147110: [symbolizer] Treat invalid address as addr2line does

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff created this revision.
sepavloff added reviewers: jhenderson, mysterymath, MaskRay, dblaikie, ikudrin, dvyukov.
Herald added a subscriber: hiraditya.
Herald added a project: All.
sepavloff requested review of this revision.
Herald added a project: LLVM.

llvm-symbolizer echoed input if it was not recognized as a valid address.
This behavior was extended to llvm-addr2line as well. GNU addr2line in
this case optputs "??:0". This difference prevents implementation of
symbol+offset lookup available in the recent versions of GNU binutils.
In that case a string that is not an address may be a symbol.

This change make reaction of llvm-addr2line on unrecognized input closer
to GNU addr2line.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147110

Files:
  llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
  llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp
  llvm/test/tools/llvm-symbolizer/flush-output.s
  llvm/test/tools/llvm-symbolizer/input-base.test
  llvm/test/tools/llvm-symbolizer/invalid-input-address.test
  llvm/test/tools/llvm-symbolizer/options-from-env.test
  llvm/test/tools/llvm-symbolizer/output-style-empty-line.test
  llvm/test/tools/llvm-symbolizer/sym.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147110.509213.patch
Type: text/x-patch
Size: 6692 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230329/d284bf8c/attachment.bin>