[PATCH] D147059: [asan][test] Fix tests or mark XFAIL for MinGW target

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: compiler-rt/lib/asan/tests/asan_test.cpp:208
+  // https://google.github.io/googletest/advanced.html#regular-expression-syntax
+  // GoogleTest's regular expression engine on Windows does not support `[]`
+  // brackets.
----------------
alvinhochun wrote:
> mstorsjo wrote:
> > If this is specific to Windows, why is this different from the case with MSVC/clang-cl?
> MSVC target shouldn't reach here anyway because `if (sizeof(long double) == sizeof(double))` is true. I guess I can change it to `_WIN32` though.
Clang has option to override it, see https://godbolt.org/z/1x9Pd9Tfx


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147059/new/

https://reviews.llvm.org/D147059