[PATCH] D146839: [TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions

Tue Mar 28 15:13:05 PDT 2023

danielkiss accepted this revision.
danielkiss added a comment.

LGTM, thanks!

================
Comment at: llvm/include/llvm/Analysis/VecFuncs.def:21
 #define FIXED(NL) ElementCount::getFixed(NL)
 #define SCALABLE(NL) ElementCount::getScalable(NL)
+#define NOMASK 0
----------------
pawosm01 wrote:
> sdesmalen wrote:
> > danielkiss wrote:
> > > I won't introduce a new argument here, since `MASKED` is just indicate this interface is scalable so far.
> > > Can we make the declarations less verbose?
> > > e.g.: 
> > > #define FIXED(NL) ElementCount::getFixed(NL), false
> > > #define SCALABLE(NL) ElementCount::getScalable(NL), true 
> > Sorry I missed this comment yesterday, but I'm not sure I agree with the suggestion to let SCALABLE imply MASKED. The two concepts are orthogonal, they just happen to have the same value for the set of vector function mappings added in this patch.  It's perfectly possible to have an unmasked scalable interface and we may want to add those in the future.
> > 
> > The cost of adding the mask separately seemed quite low, is there another reason you prefer not to add this now?
> I tend to agree with @sdesmalen so I'm reverting to the previous shape.
I have no objection since the interface is the `struct VecDesc`, here the macro would just save some repetition.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146839/new/

https://reviews.llvm.org/D146839