[PATCH] D146854: [Symbolizer] Add flag to dump symbolizer markup context JSON.

Tue Mar 28 14:54:24 PDT 2023

mysterymath added inline comments.

================
Comment at: llvm/lib/DebugInfo/Symbolize/MarkupFilter.cpp:450
+        JOS->attribute("mode", Map.Mode);
+        JOS->attribute("moduleRelativeAddress", Map.ModuleRelativeAddr);
+        JOS->objectEnd();
----------------
phosek wrote:
> For attribute naming, in JSON generated from LLVM tools we typically use either `PascalCase` or `snake_case`, `camelCase` is a bit unusual.
I did a quick search around the codebase, and it doesn't look like there's a consistent convention; there's kebab case, pascal case, and camelCase all represented. Didn't really take the time to get accurate counts, but it does seem that various style guides suggest lower camel case:

https://google.github.io/styleguide/jsoncstyleguide.xml
https://jsonapi.org/recommendations/

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146854/new/

https://reviews.llvm.org/D146854