[PATCH] D146854: [Symbolizer] Add flag to dump symbolizer markup context JSON.

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 28 09:02:22 PDT 2023


phosek added inline comments.


================
Comment at: llvm/lib/DebugInfo/Symbolize/MarkupFilter.cpp:450
+        JOS->attribute("mode", Map.Mode);
+        JOS->attribute("moduleRelativeAddress", Map.ModuleRelativeAddr);
+        JOS->objectEnd();
----------------
For attribute naming, in JSON generated from LLVM tools we typically use either `PascalCase` or `snake_case`, `camelCase` is a bit unusual.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146854/new/

https://reviews.llvm.org/D146854



More information about the llvm-commits mailing list