[PATCH] D146893: [ADT] Work around MSVC bug affecting `get(enumerator_result)`

Tue Mar 28 08:40:20 PDT 2023

kuhar added a comment.

In D146893#4227652 <https://reviews.llvm.org/D146893#4227652>, @jmorse wrote:

> Note that I'm seeing this too with `Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29915 for x64`.

It'd be great if we had buildbots that cover a wider range of MSVC versions...

> Gah... Are you able to check if replacing std::tuple_element_t<I, value_reference_tuple> with decltype(auto) fixes that? The explicit return type was not necessary on 2022 17.1 but something I used to debug the previous failure and never bothered undoing.

Either this or moving `enable_if` to the return type should fix this, I would guess. Could either of you, @jmorse or @jurahul, try that out? This would save me a couple of hours of work as I don't have these versions available to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146893/new/

https://reviews.llvm.org/D146893