[PATCH] D140900: [DebugInfo] Print empty MDTuples wrapped in MetadataAsValue inline
Orlando Cazalet-Hyams via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 28 07:44:41 PDT 2023
Orlando updated this revision to Diff 509007.
Orlando added a comment.
Rather than using `FromValue` to determine whether the node should be printed inline I've added a parameter `AsOperand` to WriteAsOperandInternal, which is true when printing metadata with `Metadata::printAsOperand` and when printing `MetadataAsValue` wrapped operands through the `Value *` version of `WriteAsOperandInternal`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140900/new/
https://reviews.llvm.org/D140900
Files:
llvm/lib/IR/AsmWriter.cpp
llvm/test/DebugInfo/Generic/empty-metadata-roundtrip.ll
llvm/test/Transforms/GlobalOpt/localize-constexpr-debuginfo.ll
llvm/test/Transforms/GlobalOpt/metadata.ll
llvm/test/Transforms/LoopIdiom/debug-line.ll
llvm/unittests/IR/MetadataTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140900.509007.patch
Type: text/x-patch
Size: 8299 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230328/03c1529c/attachment.bin>
More information about the llvm-commits
mailing list