[PATCH] D146978: [Assignment Tracking] Improve removeRedundantDbgLocsUsingBackwardScan

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

> there's a semantic change whereby a debug intrinsic with no fragment is considered as covering the whole variable, right

I don't think there's been a change - I would argue that has always been the case.



================
Comment at: llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp:2152
   bool Changed = false;
-  SmallDenseSet<DebugVariable> VariableSet;
-
+  DenseMap<DebugAggregate, BitVector> VariableDefinedBits;
   // Scan over the entire block, not just over the instructions mapped by
----------------
jmorse wrote:
> Any particular reason for switching from SmallDenseMap to DenseMap -- there's an initial allocation for DenseMaps that's going to mean one additional malloc/free for each block, even if there's little work to be done in it.
No reason - just a typo essentially I think. I will change it back.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146978/new/

https://reviews.llvm.org/D146978