[PATCH] D145515: [Assignment Tracking][NFC] Only calculate fragment overlaps for partially stack homed variables

[Jeremy Morse via Phabricator via llvm-commits]

jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp:1879
 static AssignmentTrackingLowering::OverlapMap buildOverlapMapAndRecordDeclares(
-    Function &Fn, FunctionVarLocsBuilder *FnVarLocs,
+    Function &Fn, const DenseSet<DebugAggregate> *VarsWithStackSlot,
+    FunctionVarLocsBuilder *FnVarLocs,
----------------
Orlando wrote:
> jmorse wrote:
> > scott.linder wrote:
> > > I would prefer a reference type, assuming there is no possibility that it is `nullptr`.
> > +1,
> I have already changed `VarsWithStackSlot` (the parameter added in this patch) to a reference type - just checking, @jmorse are you asking for me to change `FnVarLocs` (not added in this patch) too?
Oh, right, this patch isn't adding that parameter. That can probably be improved some other time then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145515/new/

https://reviews.llvm.org/D145515