[PATCH] D135960: [RISCV] Allow LI with symbol difference as constant

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

In D135960#4209064 <https://reviews.llvm.org/D135960#4209064>, @asb wrote:

> In D135960#4177411 <https://reviews.llvm.org/D135960#4177411>, @asb wrote:
>
>> Could you please update the patch description to say "Fixes #57461 <https://github.com/llvm/llvm-project/issues/57461>" or similar?
>>
>> I think all the review comments are addressed and I don't have additional feedback - the only open line of discussion I think was about how `fixup_riscv_12_i` is the only fixup that can never result in a relocation (as pointed out by @jrtc27). That's true, but I also can't see an alternative way of handling it or any real disadvantage of this - it logically _is_ a fixup. Do you see an alternative approach, or was it more that you think it would make sense to adjust the naming so it's clearer it doesn't have a matching relocation?
>
> Rereading this, I wasn't very clear who I was directing my question to - I meant to direct it at @jrtc27 - what do you think?

@jrtc27 - pinging to check you're happy landing this patch. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135960/new/

https://reviews.llvm.org/D135960