[PATCH] D146848: [lvm-windres] Try to match GNU windres regarding handling of unescaped quotes

Tue Mar 28 00:59:42 PDT 2023

mstorsjo added a comment.

In D146848#4221771 <https://reviews.llvm.org/D146848#4221771>, @mstorsjo wrote:

> In D146848#4221240 <https://reviews.llvm.org/D146848#4221240>, @mati865 wrote:
>
>> Oh, that's unfortunate.
>> Maybe `llvm-windres` should generate a warning in such case?
>
> Hmm, maybe... (I'd need to think about it again to sort my thoughts out about it; I had written this patch 6 months ago but never took the time to finish it to have it reviewed.)

I think I'll skip adding a warning in this case, as I think it feels somewhat out of place. Whenever debugging such uses, we should have mostly consistent behaviour between GNU windres and LLVM windres anyway. The user can see the actual preprocessing command that gets run by running windres with `-v`/`--verbose` too, which is helpful for figuring out the right amount of quoting/escaping.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146848/new/

https://reviews.llvm.org/D146848