[PATCH] D144128: [SLP] Check with target before vectorizing GEP Indices

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D144128#4220571 <https://reviews.llvm.org/D144128#4220571>, @jonpa wrote:

> It would be ok for me if you reverted it while investigating regressions. I would hope then that you would try the "partial revert" meaning removing just the change in NotProfitableForVectorization().

Unfortunately that didn't help, so I went ahead and reverted the whole commit for now.

> Since targets are different and cost tuning is coarse and difficult, maybe it would make sense to change this hook so that there are different levels of preference. It should be possible to use it as is, but for your targets you could keep using it but only where you wanted to...

Sounds reasonable to me! Another issue that might be worth checking out may be why `llvm/test/Transforms/SLPVectorizer/AArch64/vector-getelementptr.ll` isn't vectorized except for the vector-gep when those GEPs are not part of the seed instructions .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144128/new/

https://reviews.llvm.org/D144128