[PATCH] D146963: [SimpleLoopUnswitch] Fix SCEV invalidation for unswitchTrivialSwitch

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 27 23:57:55 PDT 2023


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks for tracking down a test case for this!



================
Comment at: llvm/test/Transforms/SimpleLoopUnswitch/update-scev-2.ll:7
+;
+;   opt: ../lib/Analysis/ScalarEvolution.cpp:8569: const llvm::SCEV* llvm::ScalarEvolution::BackedgeTakenInfo::getExact(const llvm::Loop*, llvm::ScalarEvolution*, llvm::SmallVector<const llvm::SCEVPredicate*, 4>*) const: Assertion `SE->DT.dominates(ENT.ExitingBlock, Latch) && "We should only have known counts for exiting blocks that dominate " "latch!"' failed.
+;   Stack dump:
----------------
I think it is probably better to avoid including a stack trace here, as it may go stable. Just staying it will fail verification would be sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146963/new/

https://reviews.llvm.org/D146963



More information about the llvm-commits mailing list