[PATCH] D128132: [Support/BLAKE3] Enable the SIMD implementations for macOS universal builds

Mon Mar 27 23:51:16 PDT 2023

thevinster added a comment.

We've just recently updated our version of LLVM (I know we're slow...), and this patch breaks our builds when building LLVM for macOS Universal and with LTO. Specifically, this is the error I get when building for such configuration.

  error: archive member blake3_sse2_x86-64_unix.S.o is a MachO, while previous archive member blake3.c.o was an IR LLVM object

Is there anyway to support LTO configurations with this patch? I've added a temporary internal patch on top of our mirror of LLVM that disables the assembly files, but it would be nice if there's a way to have that be supported.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128132/new/

https://reviews.llvm.org/D128132