[llvm] e844638 - [llvm] Use isIntOrFPConstant (NFC)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 27 22:32:35 PDT 2023
Author: Kazu Hirata
Date: 2023-03-27T22:32:23-07:00
New Revision: e8446389462b9eb3ce076f5ba3cba7e35b469e37
URL: https://github.com/llvm/llvm-project/commit/e8446389462b9eb3ce076f5ba3cba7e35b469e37
DIFF: https://github.com/llvm/llvm-project/commit/e8446389462b9eb3ce076f5ba3cba7e35b469e37.diff
LOG: [llvm] Use isIntOrFPConstant (NFC)
Added:
Modified:
llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
llvm/lib/CodeGen/SelectionDAG/StatepointLowering.cpp
llvm/lib/Target/X86/X86ISelLowering.cpp
Removed:
################################################################################
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
index 37fbe251cda4..1abbe9b52121 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
@@ -1590,7 +1590,7 @@ SDValue SelectionDAGBuilder::getNonRegisterValue(const Value *V) {
// If we already have an SDValue for this value, use it.
SDValue &N = NodeMap[V];
if (N.getNode()) {
- if (isa<ConstantSDNode>(N) || isa<ConstantFPSDNode>(N)) {
+ if (isIntOrFPConstant(N)) {
// Remove the debug location from the node as the node is about to be used
// in a location which may
diff er from the original debug location. This
// is relevant to Constant and ConstantFP nodes because they can appear
diff --git a/llvm/lib/CodeGen/SelectionDAG/StatepointLowering.cpp b/llvm/lib/CodeGen/SelectionDAG/StatepointLowering.cpp
index 57bfe344dbab..24e5824063d0 100644
--- a/llvm/lib/CodeGen/SelectionDAG/StatepointLowering.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/StatepointLowering.cpp
@@ -258,8 +258,7 @@ static bool willLowerDirectly(SDValue Incoming) {
if (Incoming.getValueType().getSizeInBits() > 64)
return false;
- return (isa<ConstantSDNode>(Incoming) || isa<ConstantFPSDNode>(Incoming) ||
- Incoming.isUndef());
+ return isIntOrFPConstant(Incoming) || Incoming.isUndef();
}
/// Try to find existing copies of the incoming values in stack slots used for
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index b0d9c97b5853..13e072a577a7 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -11249,7 +11249,7 @@ X86TargetLowering::LowerBUILD_VECTOR(SDValue Op, SelectionDAG &DAG) const {
continue;
}
Values.insert(Elt);
- if (!isa<ConstantSDNode>(Elt) && !isa<ConstantFPSDNode>(Elt)) {
+ if (!isIntOrFPConstant(Elt)) {
IsAllConstants = false;
NumConstants--;
}
More information about the llvm-commits
mailing list