[PATCH] D146813: [LICM] Reassociate GEPs to allow hoisting

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 27 19:55:39 PDT 2023


mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:2536
+      Builder.CreateGEP(GEP->getSourceElementType(), SrcPtr,
+                        SmallVector<Value *>(GEP->indices()), "", IsInBounds);
+  Builder.SetInsertPoint(GEP);
----------------
Can you please add a test where GEP and Src's indices have different dimensions? I'm a bit worried about type compatibility here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146813/new/

https://reviews.llvm.org/D146813



More information about the llvm-commits mailing list