[PATCH] D146880: Make git ignore core files

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added inline comments.
This revision is now accepted and ready to land.


================
Comment at: .gitignore:26
+# Ignore core files that might accidentally end up in the repository.
+*core
 
----------------
Should this be just `core` (i.e. without the `*`)? At least on Linux `core` is the default core file name, right? An on macOS they're off by default and end up under `/cores` anyway. 

We have a few core files checked in as part of the LLDB test suite but they usually have a descriptive name, such as `subject.core` that would get matched with the current pattern.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146880/new/

https://reviews.llvm.org/D146880