[PATCH] D146759: Declaration fragments for properties include additional property attributes that were not specified in the sources proposed solution

[Zixu Wang via Phabricator via llvm-commits]

zixuw requested changes to this revision.
zixuw added a comment.
This revision now requires changes to proceed.

Please update/add test cases.



================
Comment at: CONTRIBUTING.md:10-18
+
+## Getting in touch
+
+Join the [LLVM Discourse forums](https://discourse.llvm.org/), [Discord
+chat](https://discord.gg/xS7Z362), or #llvm IRC channel on
+[OFTC](https://oftc.net/).
+
----------------
Do not include irrelevant changes.


================
Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:629-630
 
-  const auto Attributes = Property->getPropertyAttributes();
+  // changed the getPropertyAttributes() to getPropertyAttributesAsWritten() 
+  // in following line when calling Property->getPropertyAttributesAsWritten();
+  const auto Attributes = Property->getPropertyAttributesAsWritten();
----------------
Do not use comments to describe the change you've made.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146759/new/

https://reviews.llvm.org/D146759