[PATCH] D146759: Declaration fragments for properties include additional property attributes that were not specified in the sources proposed solution

[Usman Akinyemi via Phabricator via llvm-commits]

Unique_Usman updated this revision to Diff 508782.
Unique_Usman added a comment.

changed the getPropertyAttributes() to getPropertyAttributesAsWritten() which is the function for getting the property declared by the user.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146759/new/

https://reviews.llvm.org/D146759

Files:
  CONTRIBUTING.md
  clang/lib/ExtractAPI/DeclarationFragments.cpp


Index: clang/lib/ExtractAPI/DeclarationFragments.cpp
===================================================================
--- clang/lib/ExtractAPI/DeclarationFragments.cpp
+++ clang/lib/ExtractAPI/DeclarationFragments.cpp
@@ -626,7 +626,9 @@
   // Build the Objective-C property keyword.
   Fragments.append("@property", DeclarationFragments::FragmentKind::Keyword);
 
-  const auto Attributes = Property->getPropertyAttributes();
+  // changed the getPropertyAttributes() to getPropertyAttributesAsWritten() 
+  // in following line when calling Property->getPropertyAttributesAsWritten();
+  const auto Attributes = Property->getPropertyAttributesAsWritten();
   // Build the attributes if there is any associated with the property.
   if (Attributes != ObjCPropertyAttribute::kind_noattr) {
     // No leading comma for the first attribute.
Index: CONTRIBUTING.md
===================================================================
--- CONTRIBUTING.md
+++ CONTRIBUTING.md
@@ -7,3 +7,12 @@
 [Contributing to LLVM](https://llvm.org/docs/Contributing.html) guide. It
 describes how to get involved, raise issues and submit patches. Please note
 that at the moment the LLVM project does not use GitHub pull requests.
+
+## Getting in touch
+
+Join the [LLVM Discourse forums](https://discourse.llvm.org/), [Discord
+chat](https://discord.gg/xS7Z362), or #llvm IRC channel on
+[OFTC](https://oftc.net/).
+
+The LLVM project has adopted a [code of conduct](https://llvm.org/docs/CodeOfConduct.html) for
+participants to all modes of communication within the project.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146759.508782.patch
Type: text/x-patch
Size: 1563 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230327/9dda2807/attachment-0001.bin>