[PATCH] D146905: [IR] Add llvm.tan.* intrinsic
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 27 13:14:05 PDT 2023
craig.topper added inline comments.
================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:650
setOperationAction(ISD::FSINCOS, VT, Expand);
+ setOperationAction(ISD::FTAN , VT, Expand);
}
----------------
We should default this to Expand in llvm/lib/CodeGen/TargetLoweringBase.cpp like we do for ISD::CBRT. That will be needed to properly support other targets than X86.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146905/new/
https://reviews.llvm.org/D146905
More information about the llvm-commits
mailing list