[PATCH] D144153: [lld-macho] Support re-exports of individual symbols

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

In D144153#4225351 <https://reviews.llvm.org/D144153#4225351>, @int3 wrote:

> I don't really think a test for that is super necessary, the `-exported_symbols_list` is simply command-line sugar over `-exported_symbol`, and I don't think every variation of how `-exported_symbol` gets used needs to have a corresponding `_list` test...

Fair enough. My logic was that I personally found it surprising that `-exported_symbols_list` performs re-exporting even though there's also `-reexported_symbols_list` and thought it might be useful to be explicit about that in a test. On the other hand, like you said, since `-exported_symbols_list` is equivalent to `-exported_symbol`, it does make sense that they'd behave identically in this aspect too (and would be really weird if it didn't). Not an issue either way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144153/new/

https://reviews.llvm.org/D144153