[PATCH] D146852: [DWARF][GDB INDEX] Fix to deal with constant pool de-dupliation Summary:

Mon Mar 27 11:12:19 PDT 2023

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Thanks!

================
Comment at: llvm/test/DebugInfo/dwarfdump-dump-gdbindex-v8.test:64-68
+; CHECK-NEXT:   0(0x0): 0x90000000
+; CHECK-NEXT:   1(0x8): 0x90000001
+; CHECK-NEXT:   2(0x10): 0x30000000
+; CHECK-NEXT:   3(0x18): 0x30000001
+; CHECK-NEXT:   4(0x20): 0x90000002
----------------
If you like, perhaps in a separate patch, we could remove the numbering from this dump - since/if nothing refers to these entries by number/index, and only by offset - the index/numbering seems unneeded/misleading/confusing?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146852/new/

https://reviews.llvm.org/D146852