[PATCH] D146179: ValueTypes.td: Reorganize ValueType to generate `MachineValueType.h`

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:192
 
-  let isAny = true;
+  assert isAny, "iPTRAny should have isOverloaded";
 }
----------------
I didn't know tablegen had assertions 


================
Comment at: llvm/unittests/Support/MachineValueType.h:80
     /// Return true if this is a FP or a vector FP type.
     bool isFloatingPoint() const {
+      switch (SimpleTy) {
----------------
Have you measured compile time changes? Seems unfortunate to move from range checks to generated switches 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146179/new/

https://reviews.llvm.org/D146179