[PATCH] D146879: [dsymutil] Add the ability to generate universal binaries with a fat64 header

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 27 08:56:01 PDT 2023


aprantl added a comment.

I understand that auto-detection can be a double-edged sword, but — should this be autodetected based on the input size? Or this impossible because we only know the sizer after it's too late?



================
Comment at: llvm/tools/dsymutil/dsymutil.cpp:787
+        // Universal Mach-O files can't have an archicture slice that starts
+        // beyond the 4GB boundary. "lipo" can creeate a 64 bit universal
+        // header, but not all tools can parse these files so we want to return
----------------
typo: create


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146879/new/

https://reviews.llvm.org/D146879



More information about the llvm-commits mailing list