[PATCH] D140202: [lld][ARM][2/3]Big Endian support - Word invariant support

Mon Mar 27 08:24:37 PDT 2023

peter.smith accepted this revision.
peter.smith added a comment.

One tiny change to add some punctuation to a comment. This can be done prior to commit, no need to post another review.

I think that this satisfies MaskRay's request in https://reviews.llvm.org/D140202#4132479 to remove `--be8` from this patch. LLD now has the same interface as GNU ld for BE32. Will be worth waiting a day or so to see if there are any additional comments from the US timezone.

================
Comment at: lld/ELF/SyntheticSections.cpp:3530

-  const uint8_t cantUnwindData[8] = {0, 0, 0, 0,  // PREL31 to target
-                                     1, 0, 0, 0}; // EXIDX_CANTUNWIND
-
+  // A linker generated CANTUNWIND entry is made up of two words
+  // 0x0 with R_ARM_PREL31 relocation to target.
----------------
Just remembered the LLD convention for comments. Can you add a colon after two words and put a full stop after 0x1. essentially:
```
// A linker generated CANTUNWIND entry is made up of two words:
// 0x0 with R_ARM_PREL31 relocation to target.
// 0x1.
```

My apologies I should have made that clearer in the example.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140202/new/

https://reviews.llvm.org/D140202