[PATCH] D146958: [SCEV] Do not plant SCEV checks unnecessarily

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/vector-no-scevcheck.ll:1
+; REQUIRES: aarch64-registered-target
+; RUN: opt -passes=loop-vectorize -force-vector-interleave=1 -S < %s | FileCheck %s
----------------
Could you precommit the test?


================
Comment at: llvm/test/Transforms/LoopVectorize/vector-no-scevcheck.ll:4-5
+
+target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
+target triple = "aarch64-unknown-linux-gnu"
+
----------------
Pass these as arguments of opt call.


================
Comment at: llvm/test/Transforms/LoopVectorize/vector-no-scevcheck.ll:7
+
+define void @foo(ptr %pout, ptr readonly %pin, ptr readonly %dims1, ptr readonly %dims2) {
+; CHECK-LABEL: @foo(
----------------
The attributes can be dropped, assume


================
Comment at: llvm/test/Transforms/LoopVectorize/vector-no-scevcheck.ll:63-73
+!llvm.module.flags = !{!0}
+!llvm.ident = !{!1}
+
+!0 = !{i32 1, !"wchar_size", i32 4}
+!1 = !{!"clang"}
+!2 = !{!3, !3, i64 0}
+!3 = !{!"long", !4, i64 0}
----------------
Can you try to drop metadata too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146958/new/

https://reviews.llvm.org/D146958