[PATCH] D145586: [AMDGPU] Tweak PromoteAlloca limits
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 27 05:34:35 PDT 2023
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:409
+ ((MaxVGPRs >= 64 && !PromoteAllocaToVectorLimit) ? 2 : 4);
+ if (DL.getTypeSizeInBits(AllocaTy) * SizeFactor > Limit) {
LLVM_DEBUG(dbgs() << " Alloca too big for vectorization with "
----------------
I think it would be a bit easier to understand if this was all done in terms of bytes, and then checked against getTypeStoreSize
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145586/new/
https://reviews.llvm.org/D145586
More information about the llvm-commits
mailing list