[PATCH] D146225: [AMDGPU] Handle memset users in PromoteAlloca

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:399
+         match(I->getOperand(2), m_SpecificInt(Size)) &&
+         match(I->getOperand(3), m_Zero());
+}
----------------
!I->isVolatile() would be clearer


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:637
+        // no-op, but it's better to be safe.
+        MSI->setOperand(2, Builder.getInt64(DL.getTypeStoreSize(VectorTy)));
       } else {
----------------
I don't see how this could differ with the current code


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146225/new/

https://reviews.llvm.org/D146225