[PATCH] D146031: [AMDGPU] Add MMOs for GFX11 Streamout Instructions

[Diana Picus via Phabricator via llvm-commits]

rovka updated this revision to Diff 508567.
rovka added a comment.

I have expanded the section in `AMDGPUUsage.rst`. Hopefully this clarifies the intention, but do let me know if I anything could use rephrasing.

I had a stab at catching IR pointers to this address space in the IR Verifier, but AFAICT we shouldn't import `lib/Target/AMDGPU/AMDGPU.h` there, so we wouldn't have access to our address space enum. I don't think it's worth the effort of maintaining the internal address space numbering in yet another place, so I'm abandoning that idea.

Regarding the alias info for these intrinsics - we don't seem to be doing anything special for other intrinsics (we're not overriding `AAResult::getModRefInfo` at all). So that should probably be a different patch anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146031/new/

https://reviews.llvm.org/D146031

Files:
  llvm/docs/AMDGPUUsage.rst
  llvm/include/llvm/IR/IntrinsicsAMDGPU.td
  llvm/lib/Target/AMDGPU/AMDGPU.h
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/test/CodeGen/AMDGPU/llvm.amdgcn.ds.add.gs.reg.rtn.ll
  llvm/test/CodeGen/AMDGPU/llvm.amdgcn.ds.sub.gs.reg.rtn.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146031.508567.patch
Type: text/x-patch
Size: 8694 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230327/2b6a90a9/attachment.bin>