[PATCH] D146839: [PATCH] [TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions

[Daniel Kiss via Phabricator via llvm-commits]

danielkiss added a comment.

I'd add note to the documentation too when scalable vectors are used the sleef library is expect to be compiled with it.



================
Comment at: llvm/include/llvm/Analysis/VecFuncs.def:21
 #define FIXED(NL) ElementCount::getFixed(NL)
 #define SCALABLE(NL) ElementCount::getScalable(NL)
+#define NOMASK 0
----------------
I won't introduce a new argument here, since `MASKED` is just indicate this interface is scalable so far.
Can we make the declarations less verbose?
e.g.: 
#define FIXED(NL) ElementCount::getFixed(NL), false
#define SCALABLE(NL) ElementCount::getScalable(NL), true 


================
Comment at: llvm/lib/Analysis/VectorUtils.cpp:1532
                                        StringRef ScalarName, unsigned numArgs,
-                                       ElementCount VF) {
+                                       ElementCount VF, bool GlobalPredicate) {
   SmallString<256> Buffer;
----------------
for me the "Global" naming is a bit misleading or am I missing something?
Masked maybe?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146839/new/

https://reviews.llvm.org/D146839