[PATCH] D146851: [support] Revise ScopedPrinter formatting tests for floats
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 27 00:53:42 PDT 2023
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, but should get the AIX/Solaris people have verified the fix.
================
Comment at: llvm/unittests/Support/ScopedPrinterTest.cpp:513
+// Format floats using the same format string as PrintNumber, so we can check
+// the output on all platforms
+template <typename T,
----------------
Nit
================
Comment at: llvm/unittests/Support/ScopedPrinterTest.cpp:524
+// Format floats using the same format string used in JSON, so we can check the
+// output on all platforms
+template <typename T,
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146851/new/
https://reviews.llvm.org/D146851
More information about the llvm-commits
mailing list