[PATCH] D146789: [LegalizeTypes][TargetLowering][RISCV] Fix regressions from D146786.

Liao Chunyu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 26 18:05:46 PDT 2023


liaolucy accepted this revision.
liaolucy added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/overflow-intrinsics.ll:663
 
 define i1 @uaddo_i64_decrement_alt(i64 %x, ptr %p) {
 ; RV32-LABEL: uaddo_i64_decrement_alt:
----------------
craig.topper wrote:
> liaolucy wrote:
> > RV32 and RV64 each add an mv(COPY) instruction, the instruction is added by virtregrewriter.
> > 
> > But the whole is good, maybe we can add a todo, lest we forget.
> Functions this small aren’t representative of register allocation on longer functions. I would hope this function would be inlined.
thanks, LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146789/new/

https://reviews.llvm.org/D146789



More information about the llvm-commits mailing list