[PATCH] D145937: Replace `IntrinsicEmitter::ComputeFixedEncoding()` and cleanup

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni created this revision.
Herald added subscribers: mgrang, hiraditya.
Herald added a project: All.
chapuni edited the summary of this revision.
chapuni updated this revision to Diff 505119.
chapuni added a comment.
chapuni updated this revision to Diff 505315.
chapuni edited the summary of this revision.
chapuni updated this revision to Diff 505319.
chapuni updated this revision to Diff 505521.
chapuni edited the summary of this revision.
chapuni edited the summary of this revision.
chapuni edited the summary of this revision.
chapuni updated this revision to Diff 505942.
chapuni updated this revision to Diff 506440.
chapuni edited the summary of this revision.
Herald added subscribers: kosarev, kerbowa, jvesely, qcolombet.
chapuni updated this revision to Diff 507182.
chapuni edited the summary of this revision.
chapuni updated this revision to Diff 508414.
chapuni retitled this revision from "TableGen: Let Intrinsics.td emit TypeSig" to "Replace `IntrinsicEmitter::ComputeFixedEncoding()` and cleanup".
chapuni edited the summary of this revision.
chapuni published this revision for review.
Herald added subscribers: llvm-commits, jdoerfert.
Herald added a project: LLVM.

- Update (w/ some fixups)


chapuni added a comment.

Rebase on D143844 <https://reviews.llvm.org/D143844>


chapuni added a comment.

Restore the last cleanup


chapuni added a comment.

- Update for recent changes


chapuni added a comment.

- Update


chapuni added a comment.

- Merge D146147 <https://reviews.llvm.org/D146147>


chapuni added a comment.

- Reflect D145872 <https://reviews.llvm.org/D145872>


chapuni added a comment.

- Split out preceding changes



================
Comment at: llvm/include/llvm/CodeGen/ValueTypes.td:29
+class VTAny<int value> : ValueType<0, value> {
+  let isOverloaded = true;
+}
----------------
Does this mean it's now possible to define codegen patterns that accept different types? e.g. a single store pattern that accepts i32 and f32 inputs?


================
Comment at: llvm/include/llvm/CodeGen/ValueTypes.td:29
+class VTAny<int value> : ValueType<0, value> {
+  let isOverloaded = true;
+}
----------------
arsenm wrote:
> Does this mean it's now possible to define codegen patterns that accept different types? e.g. a single store pattern that accepts i32 and f32 inputs?
I suppose this is just a convention for coming MVTEmitter to emit `MVT::isOverloaded()`. I have no idea if we could enhance semantics.


Depends on D146915 <https://reviews.llvm.org/D146915>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145937

Files:
  llvm/include/llvm/IR/Intrinsics.td
  llvm/utils/TableGen/CodeGenDAGPatterns.cpp
  llvm/utils/TableGen/CodeGenIntrinsics.cpp
  llvm/utils/TableGen/CodeGenIntrinsics.h
  llvm/utils/TableGen/IntrinsicEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145937.508414.patch
Type: text/x-patch
Size: 22832 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230326/276aa360/attachment.bin>