[PATCH] D146876: [ThinLTO] Only import for non-prevailing interposable global variables

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: llvm/test/ThinLTO/X86/prevailing_weak_globals_import.ll:15
+;; It should also be defined in the corresponding object file
+; NM: def
+
----------------
tejohnson wrote:
> I think this will also match against the def of the longer "ret_av_ext_def" symbol. Is there a way to make it a bit tighter, e.g. something like:
> ; NM: W def
I'm using `--match-full-lines` in the FileCheck call to avoid that, and I verified that this particular check fails without my patch. I can add regex start and end line anchors if you'd prefer being more explicit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146876/new/

https://reviews.llvm.org/D146876