[PATCH] D146848: [lvm-windres] Try to match GNU windres regarding handling of unescaped quotes

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 25 14:18:47 PDT 2023


mstorsjo added a comment.

In D146848#4221240 <https://reviews.llvm.org/D146848#4221240>, @mati865 wrote:

> Oh, that's unfortunate.
> Maybe `llvm-windres` should generate a warning in such case?

Hmm, maybe... (I'd need to think about it again to sort my thoughts out about it; I had written this patch 6 months ago but never took the time to finish it to have it reviewed.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146848/new/

https://reviews.llvm.org/D146848



More information about the llvm-commits mailing list