[PATCH] D146884: [llvm-exegesis] Refactor InstructionBenchmark to Benchmark

Aiden Grossman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 25 13:39:17 PDT 2023


aidengrossman created this revision.
Herald added subscribers: mstojanovic, atanasyan, jrtc27, sdardis.
Herald added a project: All.
aidengrossman requested review of this revision.
Herald added subscribers: llvm-commits, courbet.
Herald added a project: LLVM.

When llvm-exegesis was first introduced, it only supported benchmarking
individual instructions, hence the name for the data structure storing
the data corresponding to a benchmark being called InstructionBenchmark
made sense. However, now that benchmarking arbitrary snippets is
supported, InstructionBenchmark doesn't correspond to a single
instruction. This patch refactors InstructionBenchmark to be called
Benchmark to clean up this little bit of technical debt.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146884

Files:
  llvm/tools/llvm-exegesis/lib/Analysis.cpp
  llvm/tools/llvm-exegesis/lib/Analysis.h
  llvm/tools/llvm-exegesis/lib/BenchmarkCode.h
  llvm/tools/llvm-exegesis/lib/BenchmarkResult.cpp
  llvm/tools/llvm-exegesis/lib/BenchmarkResult.h
  llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
  llvm/tools/llvm-exegesis/lib/BenchmarkRunner.h
  llvm/tools/llvm-exegesis/lib/Clustering.cpp
  llvm/tools/llvm-exegesis/lib/Clustering.h
  llvm/tools/llvm-exegesis/lib/CodeTemplate.h
  llvm/tools/llvm-exegesis/lib/LatencyBenchmarkRunner.cpp
  llvm/tools/llvm-exegesis/lib/LatencyBenchmarkRunner.h
  llvm/tools/llvm-exegesis/lib/SchedClassResolution.cpp
  llvm/tools/llvm-exegesis/lib/SchedClassResolution.h
  llvm/tools/llvm-exegesis/lib/SnippetRepetitor.cpp
  llvm/tools/llvm-exegesis/lib/SnippetRepetitor.h
  llvm/tools/llvm-exegesis/lib/Target.cpp
  llvm/tools/llvm-exegesis/lib/Target.h
  llvm/tools/llvm-exegesis/lib/UopsBenchmarkRunner.h
  llvm/tools/llvm-exegesis/llvm-exegesis.cpp
  llvm/unittests/tools/llvm-exegesis/ClusteringTest.cpp
  llvm/unittests/tools/llvm-exegesis/Mips/BenchmarkResultTest.cpp
  llvm/unittests/tools/llvm-exegesis/X86/BenchmarkResultTest.cpp
  llvm/unittests/tools/llvm-exegesis/X86/SnippetRepetitorTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146884.508338.patch
Type: text/x-patch
Size: 59106 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230325/e1c6a19c/attachment.bin>


More information about the llvm-commits mailing list