[PATCH] D146829: [AMDGPU] Remove unnecessary waitcnts
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Mar 25 05:02:54 PDT 2023
foad added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:1393
// TODO: Use the (TSFlags & SIInstrFlags::LGKM_CNT) property everywhere.
- if (TII->isDS(Inst) && TII->usesLGKM_CNT(Inst)) {
if (TII->isAlwaysGDS(Inst.getOpcode()) ||
----------------
Might be better to make usesLGKM_CNT itself more accurate, by tweaking DSInstructions.td so that LGKM_CNT is set to 0 for instructions that don't use it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146829/new/
https://reviews.llvm.org/D146829
More information about the llvm-commits
mailing list