[PATCH] D145650: [X86] Create extra prolog/epilog for stack realignment

Fri Mar 24 18:55:39 PDT 2023

LuoYuanke added a comment.

> repro_test`Halide::Runtime::Internal::halide_get_cpu_features:
>
>   0x55555806e23e <+1246>: movq   -0x48(%rbp), %r10
>   0x55555806e242 <+1250>: leaq   -0x28(%rbp), %rsp
>   0x55555806e246 <+1254>: popq   %rbx
>   0x55555806e247 <+1255>: popq   %r12
>   0x55555806e249 <+1257>: popq   %r13
>   0x55555806e24b <+1259>: popq   %r14
>   0x55555806e24d <+1261>: popq   %r15
>   0x55555806e24f <+1263>: popq   %rbp
>   0x55555806e250 <+1264>: leaq   -0x10(%r10), %rsp
>
> ->  0x55555806e254 <+1268>: retq
> (lldb) x/2 $rsp
> 0x7fffffffb810: 0xffffb890 0x00007fff
> (lldb) x/2 0x7fffffffb818
> 0x7fffffffb818: 0x5806dc35 0x00005555
>
>   

Thank you very much for the indicator. It seems the offset is incorrect for ` leaq   -0x10(%r10), %rsp`. It should be ` leaq   -0x8(%r10), %rsp`. Sorry for inconvenience. I'll fix it as soon as possible and I'll develop more runtime test case for it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145650/new/

https://reviews.llvm.org/D145650