[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

[Augusto Noronha via Phabricator via llvm-commits]

augusto2112 added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6775
 
+static void handleTrampolineMangledTarget(Sema &S, Decl *D,
+                                          const ParsedAttr &AL) {
----------------
augusto2112 wrote:
> erichkeane wrote:
> > I don't see anything for instantiating this in a template? As it is, I think this attribute will be dropped if on a primary template. What about dependent arguments?
> > 
> > Should we prevent this from being placed on function templates?
> I'll double check the template case!
Could you elaborate what potential problem you suspect with templates? I couldn't find any problems when using this in templated functions. The attribute should only work on functions/methods ("`SubjectList<[Function]>`") so we shouldn't need to worry about it being applied to other types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146595/new/

https://reviews.llvm.org/D146595