[PATCH] D146744: [WebAssembly] Redesign DebugValueManager

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 13:45:56 PDT 2023


aheejin added a comment.

In D146744#4220624 <https://reviews.llvm.org/D146744#4220624>, @aheejin wrote:

> Remove test `clone_different_bb_same_place`

I'm planning to make a follow-up CL that does nothing in case sinking is a no-op (i.e., sinking to the same place) to prevent unnecessary creation of `DBG_VALUE $noreg`s, and I created `sink_to_same_place` and `clone_different_bb_same_place` to show the improvement in that next CL. But I think it doesn't apply to the cloning case, because `RegStackify` assumes cloning creates new instructions anyway whether the destination is same or not. So deleted that test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146744/new/

https://reviews.llvm.org/D146744



More information about the llvm-commits mailing list