[PATCH] D141355: [AMDGPUUnifyDivergentExitNodes] Add NewPM support

[Anshil Gandhi via Phabricator via llvm-commits]

gandhi21299 added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUUnifyDivergentExitNodes.cpp:192-193
 
-bool AMDGPUUnifyDivergentExitNodes::runOnFunction(Function &F) {
-  DominatorTree *DT = nullptr;
-  if (RequireAndPreserveDomTree)
-    DT = &getAnalysis<DominatorTreeWrapperPass>().getDomTree();
-
-  auto &PDT = getAnalysis<PostDominatorTreeWrapperPass>().getPostDomTree();
+bool AMDGPUUnifyDivergentExitNodesImpl::run(Function &F, DominatorTree *DT,
+                                            const PostDominatorTree &PDT,
+                                            const UniformityInfo &UA) {
----------------
arsenm wrote:
> When is DT null but PDT won't be?
This pass depends on PDT so it can never be null. DT may be null if it does not need to be preserved, which is specified by `-simplifycfg-require-and-preserve-domtree`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141355/new/

https://reviews.llvm.org/D141355