[PATCH] D123515: [RISCV] Support '.option arch' directive

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2322
+        if (IsExtensionList)
+          return Error(
+              ArchLoc,
----------------
unneeded line wrapping? Did you use git clang-format on the modified lines?


================
Comment at: llvm/test/MC/RISCV/option-arch.s:93
+# Test arch string without version number
+#CHECK: .option arch, rv32i2p0_m2p0_a2p0_c2p0
+.option arch, rv32imac
----------------
here and throughout, add a space in `#CHECK:`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123515/new/

https://reviews.llvm.org/D123515