[PATCH] D146737: [AMDGPU] Default component broadcast store

Mateja Marjanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 09:30:03 PDT 2023


matejam added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstCombineIntrinsic.cpp:360
+  std::vector<int> Components(VWidth, -1);
+  std::map<Value *, int> MapValueInt;
+  int LastElem = 0;
----------------
matejam wrote:
> arsenm wrote:
> > Don't use std::map. Also, can this just be a SmallVector in the reverse direction per component?
> I will look into that.
What about MapVector?
I'm not sure how would I use SmallVector to implement a map?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146737/new/

https://reviews.llvm.org/D146737



More information about the llvm-commits mailing list