[PATCH] D146786: [CodeGenPrepare][RISCV] Correct the MathUsed flag for shouldFormOverflowOp

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 09:25:30 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:1591
+    } else
       return false;
   }
----------------
RKSimon wrote:
> Why can't you keep the existing !matchUAddWithOverflowConstantEdgeCases(Cmp, Add) early out code?
I can. I think I misunderstood the control flow here. I’ll change it back


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146786/new/

https://reviews.llvm.org/D146786



More information about the llvm-commits mailing list