[PATCH] D142219: [MC] Store operand info immediately after the TargetInsts table. NFC.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 07:42:47 PDT 2023

foad marked 2 inline comments as done.
foad added inline comments.

Comment at: llvm/include/llvm/MC/MCInstrDesc.h:577
   ArrayRef<MCPhysReg> implicit_defs() const {
     auto ImplicitOps = reinterpret_cast<const MCPhysReg *>(this + Opcode + 1);
     return {ImplicitOps + ImplicitOffset + NumImplicitUses, NumImplicitDefs};
foad wrote:
> barannikov88 wrote:
> > foad wrote:
> > > barannikov88 wrote:
> > > > ImplicitOps -> OpInfo (this is where it points now)
> > > > 
> > > > 
> > > You're right that it points to the start of the OpInfo, but I'm not sure that's important. It's also the "origin" from which implicit op list offsets are measured. So maybe `ImplicitOpOrigin`?
> > I mean that it now points to explicit ops. Implicit ops follow explicit ops (offseted by `ImplicitOffset`). 
> > Please correct me if I'm wrong.
> > 
> Yes, you are correct, it points to explicit ops. I just meant that that does not necessarily mean the variable has to be called "OpInfo".
Rather than change the name, I tweaked the expression so that ImplicitOps now points to the first list of implicit ops for this instruction.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list