[PATCH] D144274: [InstCombine] use loop info when running the pass after loop vectorization

Fri Mar 24 06:58:32 PDT 2023

david-arm added a comment.

In D144274#4219354 <https://reviews.llvm.org/D144274#4219354>, @fhahn wrote:

> In D144274#4216205 <https://reviews.llvm.org/D144274#4216205>, @david-arm wrote:
>
>> I think I've found the problem - the patch was missing another case that needs the loop info option.
>
> great, would it be possible to add a phase ordering test that demonstrates the issue and shows that it is fixed with the latest version?

I can certainly try, although I don't really know what a `phase ordering test` is. The phases haven't changed I don't think - we're just definitely ensuring we have loop info instead of hoping it was cached. Can you provide any examples of other tests that I can look at?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144274/new/

https://reviews.llvm.org/D144274