[PATCH] D123515: [RISCV] Support '.option arch' directive

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 06:54:03 PDT 2023


luismarques added inline comments.


================
Comment at: llvm/test/MC/RISCV/option-arch.s:64
+
+# Test comma-seperated list
+# CHECK: arch, +m, +a
----------------
Nit: separated


================
Comment at: llvm/test/MC/RISCV/option-arch.s:108
+
+.option arch, -c, +c
+# CHECK-INST: c.mv a0, a1
----------------
You should also test that something like `+d, -d` enables the dependent extensions (`f`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123515/new/

https://reviews.llvm.org/D123515



More information about the llvm-commits mailing list