[PATCH] D146128: [SVE][LoopVectorize] Add option to disable tail-folding for reverse loops

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:3399-3402
+        int Stride = getPtrStride(*PSE, AccessTy, Ptr, TheLoop, Strides,
+                                  /*Assume=*/true, /*ShouldCheckWrap=*/false)
+                         .value_or(0);
+        if (Stride == -1)
----------------
nit: you could do:

  if (getPtrStride(...).value_or(0) == -1)

directly?


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:3402
+                         .value_or(0);
+        if (Stride == -1)
+          return true;
----------------
Does it also need to return `true` for Strides < -1?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146128/new/

https://reviews.llvm.org/D146128